Fix heap use-after-free in thread/thread_manager.cc#846
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Fix heap use-after-free in thread/thread_manager.cc#846copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_943925826
branch
from
6b28026 to
acf327c
Compare
Details are in the bug, but briefly: when thread_limit == INT_MAX, the counter queue_running is deliberately not maintained. When the pool is shut down, outstanding work items are enumerated and tracked retroactively. However, any work scheduled _after_ this retroactive tracking is not itself tracked, resulting in premature freeing of data structures. We thus modify the code to enable tracking once shutdown has started, even under thread_limit == INT_MAX. PiperOrigin-RevId: 943925826
copybara-service
Bot
force-pushed
the
test_943925826
branch
from
acf327c to
06da4bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix heap use-after-free in thread/thread_manager.cc
Details are in the bug, but briefly: when thread_limit == INT_MAX, the counter queue_running is deliberately not maintained. When the pool is shut down, outstanding work items are enumerated and tracked retroactively. However, any work scheduled after this retroactive tracking is not itself tracked, resulting in premature freeing of data structures.
We thus modify the code to enable tracking once shutdown has started, even under thread_limit == INT_MAX.