Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two critical and two moderate issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
Updates C# proxy generation to emit only types reachable from service signatures and remove obsolete generated files.
Changes:
- Adds recursive type discovery and framework-type filtering.
- Handles generic and ambiguous type references.
- Expands tests for regeneration, naming, and casing behavior.
| File | Summary |
|---|---|
framework/test/Volo.Abp.Cli.Core.Tests/Volo/Abp/Cli/ServiceProxying/CSharp/CSharpServiceProxyGenerator_Tests.cs |
Tests selective generation and cleanup. Moderate issue (1 vote): casing-only file moves may fail on case-insensitive filesystems. |
framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ServiceProxying/CSharp/CSharpServiceProxyGenerator.cs |
Implements selective generation, filtering, qualification, and cleanup. Critical issues (3 votes, 1 vote): incompatible StringComparer API and invalid nested-type name generation. Moderate issue (3 votes): ambiguity detection omits signature types when contracts are excluded. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #26205 +/- ##
==========================================
+ Coverage 49.90% 50.29% +0.38%
==========================================
Files 3842 3842
Lines 135458 135607 +149
Branches 10271 10295 +24
==========================================
+ Hits 67597 68198 +601
+ Misses 65823 65346 -477
- Partials 2038 2063 +25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


CSharpServiceProxyGeneratornow generates the DTOs and enums reachable from the service signatures instead of every type under the service namespace, so a client without the*.Application.Contractsreference compiles.System.*,Microsoft.*andVolo.*types come from their packages and are no longer generated, same-named types are referenced by their full names, and regenerating removes the generated files that are no longer needed.