🎨 Palette: Add structural newlines and stderr streaming for interactive prompts#1049
Conversation
…ve prompts Co-authored-by: abhimehro <84992105+abhimehro@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
😎 This pull request was merged. |
Visual recap — skippedThe visual recap job did not run for this pull request. This is informational only and does not block the PR. Recap skipped for |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| captured = capsys.readouterr() | ||
| assert "Unrecognized input" in captured.out | ||
| assert "Unrecognized input" in captured.err |
| assert main.EMPTY_INPUT_HINT in captured.out | ||
| assert main.INVALID_INPUT_HINT in captured.out | ||
| assert "\033[2m" not in captured.out # Colors.DIM should not be there | ||
| assert main.EMPTY_INPUT_HINT in captured.err |
| assert main.INVALID_INPUT_HINT in captured.out | ||
| assert "\033[2m" not in captured.out # Colors.DIM should not be there | ||
| assert main.EMPTY_INPUT_HINT in captured.err | ||
| assert main.INVALID_INPUT_HINT in captured.err |
| assert "\033[2m" not in captured.out # Colors.DIM should not be there | ||
| assert main.EMPTY_INPUT_HINT in captured.err | ||
| assert main.INVALID_INPUT_HINT in captured.err | ||
| assert "\033[2m" not in captured.err # Colors.DIM should not be there |
| # Check that we emitted the colored strings for hints | ||
| assert f"\033[2m{main.EMPTY_INPUT_HINT}\033[0m" in captured.out | ||
| assert f"\033[2m{main.INVALID_INPUT_HINT}\033[0m" in captured.out | ||
| assert f"\033[2m{main.EMPTY_INPUT_HINT}\033[0m" in captured.err |
| assert f"\033[2m{main.EMPTY_INPUT_HINT}\033[0m" in captured.out | ||
| assert f"\033[2m{main.INVALID_INPUT_HINT}\033[0m" in captured.out | ||
| assert f"\033[2m{main.EMPTY_INPUT_HINT}\033[0m" in captured.err | ||
| assert f"\033[2m{main.INVALID_INPUT_HINT}\033[0m" in captured.err |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
There was a problem hiding this comment.
Fix Code Health degradations ℹ️
Gates Passed
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
2 participants
💡 What: Added structural newlines before interactive input reprompts and properly streamed error messages to stderr.
🎯 Why: Prevents the terminal from feeling cramped when inputs fail, separates previous dense output blocks, and ensures that interactive error messages do not corrupt standard output when the tool is piped.
♿ Accessibility: Enhances readability and terminal screen reader parsing.
PR created automatically by Jules for task 7837134500624831838 started by @abhimehro