fix: handle workflow to checkout the approved commit#187
Merged
Conversation
Although we have recommended users of this repo to enable "Dismiss stale pull request approvals when new commits are pushed" the repo setting (https://github.com/abcxyz/aod-template#prerequisites), there is a vulnerability that the user pushs a new commit after the approval check and the handle workflow checks out the new commit and execute the aod handle on the unapproved new commit. Pending e2e test Signed-off-by: Suhong Qin <suhongq@google.com>
bradegler
approved these changes
Feb 26, 2026
Contributor
Author
|
tested, it is now checking out the SHA: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use SHA so that it checks out the snapshot that triggered the workflow