feat: feature-flag funkit checkout behind NEXT_PUBLIC_ENABLE_FUNKIT#3031
Open
yogurtandjam wants to merge 1 commit into
Open
feat: feature-flag funkit checkout behind NEXT_PUBLIC_ENABLE_FUNKIT#3031yogurtandjam wants to merge 1 commit into
yogurtandjam wants to merge 1 commit into
Conversation
|
@yogurtandjam is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
Gate the entire funkit integration behind a single env-var flag so it can be turned on/off per environment without code changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yogurtandjam
force-pushed
the
feat/funkit-feature-flag
branch
from
de289e4 to
1823b2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NEXT_PUBLIC_ENABLE_FUNKITenv var (defaults tofalse) to gate the entire funkit checkout integrationFunkitCheckoutrenders nothing,isFunSupplyAsset()returnsfalse, all Supply buttons use the native Aave modal'true'): existing funkit behavior is unchanged'true'alongsideNEXT_PUBLIC_FUNKIT_API_KEYChanges
src/utils/marketsAndNetworksConfig.ts— newENABLE_FUNKITconstant (matches existingENABLE_TESTNET/STAGING_ENVpattern)src/components/transactions/FunCheckout/funSupplyAssets.ts—isFunSupplyAsset()short-circuits when flag is offsrc/components/transactions/FunCheckout/FunkitCheckout.tsx—FunkitCheckout()returns null when flag is off.env.example/.env.development— declares the flag.github/actions/build/action.yml+ both workflow files — passes the flag through CITest plan
NEXT_PUBLIC_ENABLE_FUNKIT=false: supply buttons use native modal, no funkit provider mountsNEXT_PUBLIC_ENABLE_FUNKIT=true+ valid API key: funkit checkout works as before🤖 Generated with Claude Code