feat: v4 gho direct minter#8
Open
DhairyaSethi wants to merge 4 commits into
Open
Conversation
Kogaroshi
reviewed
Apr 14, 2026
| /// @inheritdoc IGhoDirectMinterV4 | ||
| function withdrawAndBurn(uint256 amount) external onlyOwnerOrGuardian { | ||
| HUB.remove(ASSET_ID, amount, address(this)); | ||
| GHO.burn(amount); |
There was a problem hiding this comment.
let's use the withdrawnAmount like in V3 version ?
Member
Author
There was a problem hiding this comment.
yeah initially i didn't bc unlike v3 pool, hub.remove doesn't cap input amount and will revert if it's excess. so exactly 'amount' will always be removed
Kogaroshi
reviewed
Apr 14, 2026
| UpgradeableOwnableWithGuardian | ||
| } from "solidity-utils/contracts/access-control/UpgradeableOwnableWithGuardian.sol"; | ||
| import {Initializable} from "openzeppelin-contracts-upgradeable/contracts/proxy/utils/Initializable.sol"; | ||
| import {SafeERC20, IERC20} from "openzeppelin-contracts/contracts/token/ERC20/utils/SafeERC20.sol"; |
Kogaroshi
reviewed
Apr 14, 2026
| minter.withdrawAndBurn(100); | ||
| } | ||
|
|
||
| function test_transferExcessToTreasury() external { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.