feat(jolt-akita): Refactor Akita adapter and lattice opening semantics#1651
Open
sumchecker wants to merge 4 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Narrow the Akita adapter surface and make lattice precommitted openings verify against their own commitments, points, layout digests, and exact setup dimension. Co-authored-by: Cursor <cursoragent@cursor.com>
Assign the packed/precommitted route when final opening entries are built so lattice partitioning no longer depends on a second ID predicate staying in sync. Co-authored-by: Cursor <cursoragent@cursor.com>
Represent packing batch proofs as explicit direct or packed variants so Akita precommitted openings no longer masquerade as packed proofs without reductions. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Warning This PR has more than 500 changed lines and does not include a spec. Large features and architectural changes benefit from a spec-driven workflow. If this PR is a bug fix, refactor, or doesn't warrant a spec, feel free to ignore this message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jolt-akitatoward a native PCS adapter surface by hiding internal Akita config/layout/sparse types and exposing only focused adapter APIs.DirectandPackedvariants so precommitted Akita openings are first-class direct/native proofs rather than packed proofs with missing reductions.Reviewer Notes
jolt-verifierintojolt-openings, and Stage 8 routing can eventually be isolated further.Test Plan
cargo clippy -p jolt-verifier -q --all-targets --features akita -- -D warningscargo clippy -p jolt-openings -q --all-targets -- -D warningscargo nextest run --release -p jolt-verifier --cargo-quiet --features akita -E 'test(akita) or test(precommitted_opening_batches_require_exact_ordered_proofs) or test(clear_batch_rejects_precommitted_count_before_main_proof)'cargo nextest run --release -p jolt-openings --cargo-quiet packing