feat: add jolt-backends (CPU backend)#1636
Draft
moodlezoup wants to merge 1 commit into
Draft
Conversation
Contributor
|
Warning This PR has more than 500 changed lines and does not include a spec. Large features and architectural changes benefit from a spec-driven workflow. If this PR is a bug fix, refactor, or doesn't warrant a spec, feel free to ignore this message. |
492cfe4 to
276b391
Compare
0649358 to
4b99d6c
Compare
ea1c317 to
7e9fe83
Compare
4b99d6c to
2591eff
Compare
Part of splitting PR #1605 (prover-stack/10-jolt-prover) into a CI-passing stack. Adds the jolt-backends crate: the bundled CPU prover backend (sumcheck kernels, commitments, openings, polynomial ops) behind the request/result backend contracts. CI note: jolt-backends's cpu-gated module is the sole consumer of a few pub(crate) sumcheck helpers, so the crate is not standalone no-default-features-clean. It is excluded from the --no-default-features clippy line here only; the next PR (jolt-prover) depends on it with default features, restoring full coverage and reverting this CI line. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2591eff to
94221b6
Compare
Contributor
Benchmark comparison (crates) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting #1605 into a reviewable, individually-CI-passing stack (2/3).
Base:
prover-stack/10a-modular-refactorAdds jolt-backends: the bundled CPU prover backend — sumcheck kernels, commitments, openings, and polynomial / eq / lagrange ops — behind the request/result backend contracts.
jolt-backends's
cpu-gated module is the sole consumer of a fewpub(crate)sumcheck helpers, so the crate is not standalone--no-default-features-clean (those helpers read as dead code withoutcpu). It is excluded from that one--no-default-featuresclippy line in this PR only; the next PR (jolt-prover) depends on jolt-backends with default features and reverts the exclusion (feature unification keepscpuon).Validation
cargo clippy --all --all-targetsinallocative,host/allocative,host,zk/--no-default-features(jolt-backends excluded) — cleancargo nextest run -p jolt-backends— 79 tests pass