Skip to content

feat: add HyperKZG zero-knowledge openings#1600

Open
markosg04 wants to merge 2 commits into
prover-stack/04-hyraxfrom
prover-stack/05-hyperkzg-zk
Open

feat: add HyperKZG zero-knowledge openings#1600
markosg04 wants to merge 2 commits into
prover-stack/04-hyraxfrom
prover-stack/05-hyperkzg-zk

Conversation

@markosg04

Copy link
Copy Markdown
Collaborator

Part of the draft Jolt prover stack.

Base: prover-stack/04-hyrax
Head: prover-stack/05-hyperkzg-zk

Adds HyperKZG ZK setup/opening support, tests, and protocol spec.

Validation before submission:

  • cargo fmt -q -- --check
  • cargo metadata --no-deps --format-version 1
  • local gh stack push simulation against a temporary bare remote
  • forbidden-path scan for handoffs/, old STACK.md, stack/, and old stack workflow

@github-actions github-actions Bot added spec Tracking issue for a feature spec implementation PR contains implementation of a spec labels Jun 9, 2026
@0xAndoroid 0xAndoroid force-pushed the prover-stack/04-hyrax branch from cfa79a0 to 131c07b Compare June 17, 2026 05:28
@0xAndoroid

0xAndoroid commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Stack maintenance — Pika is rebasing this PR onto #1599 (prover-stack/04-hyrax) and fixing CI as part of the prover stack (#1596#1606). Rebase + CI summary to follow.

@0xAndoroid 0xAndoroid force-pushed the prover-stack/05-hyperkzg-zk branch from 289808a to 627edbd Compare June 17, 2026 05:45
@0xAndoroid 0xAndoroid marked this pull request as ready for review June 17, 2026 12:01
@0xAndoroid 0xAndoroid added the claude-review-request Request a review from Claude Code label Jun 17, 2026
@0xAndoroid

0xAndoroid commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Stack maintenance — rebased onto #1599 (prover-stack/04-hyrax); CI green.

📚 Stack A: #1596#1597#1598#1599#1600 (this PR)#1601#1602#1603
📚 Stack B: #1596#1597#1604#1605#1606

#1596 and #1597 are shared by both stacks; each PR targets the one before it.

Conflict resolution

@github-actions

Copy link
Copy Markdown
Contributor

Claude code review session started: https://claude.ai/code/session_01SSHUghHhaiXRDU1SxBgbvK

@moodlezoup moodlezoup left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the HyperKZG ZK opening protocol with a focus on soundness. The Fiat-Shamir ordering is consistent between prover and verifier across all three challenge derivations (r after appending point/y_out/com; alpha/q after appending the hidden eval-commitment rows; d after appending the witnesses), so no challenge depends on a value committed later. The verifier-side length checks (com.len()+1 == ell, eval-row widths) gate all indexing before the transcript is touched, so a malformed proof can't trigger an out-of-bounds panic. I also re-derived solve_v2_fold_randomizers against the gemini blinding relations and the two-point linear system solves out exactly, and the batched pairing check expands (by powers of d) into the expected per-point KZG opening identities. No soundness or correctness issues found. One minor simplification noted inline.


Generated by Claude Code

Self::open_with_mode::<Transparent, T>(setup, evals, point, transcript)
}

fn open_with_mode<M, T>(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open_with_mode is only ever instantiated with Transparent — the ZK path goes through open_zk_inner, not here — and the body immediately debug_asserts M::PROOF_KIND == Clear. The M parameter buys nothing; folding this back into a plain open would drop the dead generality. (commit_with_mode's M is fine since it has both Transparent and Zk callers.)


Generated by Claude Code

@0xAndoroid 0xAndoroid force-pushed the prover-stack/04-hyrax branch from 131c07b to ab30576 Compare June 17, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-review-request Request a review from Claude Code implementation PR contains implementation of a spec spec Tracking issue for a feature spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants