feat: make sync staleness check configurable via --max-sync-delay#793
Open
atlas7545 wants to merge 3 commits into
Open
feat: make sync staleness check configurable via --max-sync-delay#793atlas7545 wants to merge 3 commits into
atlas7545 wants to merge 3 commits into
Conversation
Add a --max-sync-delay CLI flag and corresponding config option to allow users to configure the maximum age (in seconds) of the latest block before Helios considers itself out of sync. Previously this was hardcoded to 60 seconds. The default remains 60s, preserving existing behavior. Threaded through: CLI args → CliConfig → Config → builder → Node
- Apply rustfmt formatting to function signatures in node.rs and mod.rs - Replace manual checked_sub().unwrap_or_default() with saturating_sub() Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--max-sync-delayCLI flag and corresponding config option to allow users to configure the maximum age (in seconds) of the latest block before Helios considers itself out of sync.Previously this was hardcoded to 60 seconds in
core/src/client/node.rs. The default remains 60s, preserving existing behavior.Changes
core/src/client/node.rs— replaced hardcoded60with configurableself.max_sync_delaycore/src/client/mod.rs— passmax_sync_delaythrough toNode::new()ethereum/src/config/mod.rs— addedmax_sync_delay: u64field toConfig(default: 60)ethereum/src/config/cli.rs— addedmax_sync_delaytoCliConfigethereum/src/builder.rs— thread config value through buildercli/src/main.rs— added--max-sync-delayCLI flagopstack/src/builder.rs— pass default (60) toHeliosClient::new()linea/src/builder.rs— pass default (60) toHeliosClient::new()Usage
Compiles cleanly (
cargo checkpasses).