Apply wspeed flags immediately on player login inside residence#1446
Open
RICE0707 wants to merge 2 commits into
Open
Apply wspeed flags immediately on player login inside residence#1446RICE0707 wants to merge 2 commits into
RICE0707 wants to merge 2 commits into
Conversation
wspeed1/wspeed2 flags were not applied when a player logged in while already inside a flagged residence. The async ResidenceChangedEvent chain (callAsync -> runAtLocation) races with Minecraft's login ability packet, causing the speed to be overridden. Fix by directly setting walk speed in the synchronous delayed task after handleNewLocation. Fixes Zrips#1444
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wspeed1/wspeed2 flags were not applied when a player logged in while
already inside a flagged residence. The async ResidenceChangedEvent chain
(callAsync -> runAtLocation) races with Minecraft's login ability packet,
causing the speed to be overridden. Fix by directly setting walk speed in
the synchronous delayed task after handleNewLocation.
Fixes #1444