Skip to content

fix for $http.get().success removal in angular 1.6#233

Open
p1lare wants to merge 1 commit into
Zizzamia:masterfrom
p1lare:master
Open

fix for $http.get().success removal in angular 1.6#233
p1lare wants to merge 1 commit into
Zizzamia:masterfrom
p1lare:master

Conversation

@p1lare

@p1lare p1lare commented Dec 21, 2016

Copy link
Copy Markdown

Sorry for the white spaces changes, have no idea when it happened. Real changes are from line 552 and 724.Hope possible to merge it without whitespaces.
http://stackoverflow.com/questions/9776527/merging-without-whitespace-conflicts

@p1lare p1lare changed the title fix for .get().success removal in angular 1.6 fix for $http.get().success removal in angular 1.6 Dec 21, 2016
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 97.706% when pulling cd33dc8 on p1lare:master into b62815a on Zizzamia:master.

@killzoner

Copy link
Copy Markdown

I agree this is a blocking issue for all projects using ngTasty and wanting to upgrade to 1.6. The tests have to be fixed though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants