fix(batch): a status value the server adds later broke callers' types; type response enum fields open, keep named types closed - #31
Merged
Conversation
…; type response enum fields open, keep named types closed
Response enum fields (run, job, task and export status, ingest_status,
failure_reason) and handle status getters are now Extensible<T> =
T | (string & {}), matching the server's x-extensible-enum contract while
keeping autocomplete. The named types stay closed so they still work as
request input. vitest now typechecks tests/ via tsconfig.test.json so the
expectTypeOf assertions actually run; fixes three test type errors that
surfaced.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ds were not in biome's format Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Response enum fields were typed as closed unions, so any value the server adds later (a new status or failure reason) breaks callers' types and exhaustive handling.
What
Extensible<T> = T | (string & {})on response enum fields (run/job/task/export status, ingest status, failure reason) and the matching handle getters.RunStatus,JobStatus, …) stay closed, so passing them as request input is unchanged.tsconfig.test.json); without it theexpectTypeOfassertions never ran. Fixed the 3 type errors this exposed.No new fields or values. No version bump.
Verification
vitest run: 248 passed, 0 type errors.tsc --noEmitclean on both configs.npm run buildOK.biome checkfails only onpackage.jsonformatting, same as on main.🤖 Generated with Claude Code