Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix JPQL injection in RoomController#29

Open
ManupaKDU wants to merge 1 commit into
developmentfrom
sentinel-fix-jpql-injection-roomcontroller-2137769685941154524
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix JPQL injection in RoomController#29
ManupaKDU wants to merge 1 commit into
developmentfrom
sentinel-fix-jpql-injection-roomcontroller-2137769685941154524

Conversation

@ManupaKDU

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The RoomController.java (src/main/java/com/divudi/bean/inward/RoomController.java) had a JPQL injection vulnerability in the getSelectedItems() method. It used string concatenation with user input (getSelectText()) to build the JPQL query.
🎯 Impact: This allows an attacker to manipulate the JPQL query, potentially accessing unauthorized data or modifying the query logic.
πŸ”§ Fix: Replaced the string concatenation with a parameterized query using findByJpql(String jpql, Map<String, Object> parameters) from AbstractFacade.
βœ… Verification: Verified by running the test suite (mvn clean test), which passed successfully.


PR created automatically by Jules for task 2137769685941154524 started by @manupawickramasinghe

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant