π‘οΈ Sentinel: [CRITICAL] Fix JPQL injection in RoomController#29
π‘οΈ Sentinel: [CRITICAL] Fix JPQL injection in RoomController#29ManupaKDU wants to merge 1 commit into
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The
RoomController.java(src/main/java/com/divudi/bean/inward/RoomController.java) had a JPQL injection vulnerability in thegetSelectedItems()method. It used string concatenation with user input (getSelectText()) to build the JPQL query.π― Impact: This allows an attacker to manipulate the JPQL query, potentially accessing unauthorized data or modifying the query logic.
π§ Fix: Replaced the string concatenation with a parameterized query using
findByJpql(String jpql, Map<String, Object> parameters)fromAbstractFacade.β Verification: Verified by running the test suite (
mvn clean test), which passed successfully.PR created automatically by Jules for task 2137769685941154524 started by @manupawickramasinghe