Skip to content

🧪 Test ensure_rknn_toolkit behavior#50

Merged
manupawickramasinghe merged 1 commit into
devfrom
test-ensure-rknn-toolkit-3740701426382972987
Jun 12, 2026
Merged

🧪 Test ensure_rknn_toolkit behavior#50
manupawickramasinghe merged 1 commit into
devfrom
test-ensure-rknn-toolkit-3740701426382972987

Conversation

@ManupaKDU

Copy link
Copy Markdown

🎯 What: The issue requested tests for ensure_rknn_toolkit in frigate/util/rknn_converter.py and pointed out that the function needed to be updated to match the intended logic (dynamically installing rknn-toolkit2 if it's not available).
📊 Coverage: The function ensure_rknn_toolkit is now tested for four scenarios:

  • rknn is already installed.
  • Dynamic installation succeeds via subprocess.check_call.
  • Dynamic installation fails because pip fails (subprocess.CalledProcessError).
  • Dynamic installation fails because rknn still can't be imported after pip succeeds (ImportError).
    Result: Test coverage for this functionality is vastly improved. The function itself was also updated to include the dynamic pip installation behavior.

PR created automatically by Jules for task 3740701426382972987 started by @manupawickramasinghe

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

PR template validation failed

This PR was automatically closed because the description does not follow the pull request template.

Issues found:

  • Missing section: ## Proposed change
  • Missing section: ## Type of change
  • Missing section: ## AI disclosure
  • Missing section: ## Checklist
  • The Proposed change section is empty. Please describe what this PR does.

Please update your PR description to include all required sections from the template, then reopen this PR.

If you used an AI tool to generate this PR, please see our contributing guidelines for details.

@github-actions github-actions Bot closed this Jun 12, 2026
@manupawickramasinghe manupawickramasinghe merged commit 83482aa into dev Jun 12, 2026
4 of 11 checks passed
@manupawickramasinghe manupawickramasinghe deleted the test-ensure-rknn-toolkit-3740701426382972987 branch June 13, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants