🧹 Refactor Calculator.py to avoid eager evaluation and zero division errors#43
🧹 Refactor Calculator.py to avoid eager evaluation and zero division errors#43ManupaKDU wants to merge 1 commit into
Conversation
Calculations for addition, subtraction, multiplication, and division were previously evaluated eagerly before checking the user's selected operation. This could lead to a crash due to `ZeroDivisionError` when the user inputted `0` for `num2` even if division wasn't selected. Moved calculation logic to the respective branches. Also added a division by zero check, protected input from EOFError, and added subprocess unit tests. Co-authored-by: ManupaKDU <95234271+ManupaKDU@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Refactored
Calculator.pyto calculate operations lazily, and addedtest_calculator.py.💡 Why: Eager evaluation caused variables for addition, subtraction, multiplication, and division to be calculated before knowing which one was requested. This is computationally redundant and unsafe, as it triggers
ZeroDivisionErrorif the user enters0for the second number while choosing an operation other than division.✅ Verification: Verified by manually running and executing new
subprocess-based automated test suitetest_calculator.pywith zero-division scenarios and ensuring tests pass. Also ran the full test suite.✨ Result: Enhanced the safety and logic of the calculator avoiding unnecessary calculations and zero division crashes.
PR created automatically by Jules for task 14081644354969242976 started by @ManupaKDU