Skip to content

⚡ [perf] Optimize factor loop to O(sqrt(N)) in Solution.py#42

Open
ManupaKDU wants to merge 1 commit into
mainfrom
perf/factor-finding-opt-14845801883588724594
Open

⚡ [perf] Optimize factor loop to O(sqrt(N)) in Solution.py#42
ManupaKDU wants to merge 1 commit into
mainfrom
perf/factor-finding-opt-14845801883588724594

Conversation

@ManupaKDU

Copy link
Copy Markdown
Contributor

💡 What: Modified Solution.py to check for factors only up to the square root of the target number (while number * number <= target). When a small factor is found, its corresponding large factor (target // number) is stored and printed in reverse order later, maintaining identical output.
🎯 Why: The previous logic looped all the way up to 8462696833, which executes in $O(N)$ time. This optimization reduces the algorithmic complexity to $O(\sqrt{N})$, drastically speeding up the execution.
📊 Measured Improvement: In a benchmark run with a smaller target of 10,000,000, the original O(N) script took 1.045433s, while the optimized O(√N) version completed in 0.000481s. This yields a massive 2172x speedup. For the actual target of 8,462,696,833, the previous approach would have taken significantly longer, but now it returns the results almost instantaneously.


PR created automatically by Jules for task 14845801883588724594 started by @ManupaKDU

Co-authored-by: ManupaKDU <95234271+ManupaKDU@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant