Skip to content

CoreMIDIDevice: Fix potential crash when enumerating device names #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coelckers merged 1 commit into from
Apr 30, 2026
Merged

CoreMIDIDevice: Fix potential crash when enumerating device names #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions source/zmusic/configuration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,16 +251,27 @@ struct MidiDeviceList
}
}
#elif __APPLE__
for (int i = 0; i < MIDIGetNumberOfDestinations(); i++)
CFStringRef cfName;
char string_buffer[128];
auto destCount = MIDIGetNumberOfDestinations();
for (int i = 0; i < destCount; i++)
{
uint32_t endpoint = MIDIGetDestination(i);
auto endpoint = MIDIGetDestination(i);
if (!endpoint)
{
continue;
}
CFStringRef cfName;
cfName = nullptr;
MIDIObjectGetStringProperty(endpoint, kMIDIPropertyName, &cfName);
devices.push_back({ strdup(CFStringGetCStringPtr(cfName, kCFStringEncodingUTF8)), i, MIDIDEV_MAPPER });
if (!CFStringGetCString(cfName, string_buffer, sizeof(string_buffer), kCFStringEncodingUTF8))
{
strcpy(string_buffer, "CoreMidi device");
}
if (cfName != nullptr)
{
CFRelease(cfName);
}
devices.push_back({ strdup(string_buffer), i, MIDIDEV_MAPPER });
}
#endif
#endif
Expand Down
Loading