feat: web push notifications service (closes #16)#42
Open
Yunaido wants to merge 2 commits into
Open
Conversation
Implements browser and smartphone push notifications via the Web Push API and a service worker, addressing issue #16. - PushSubscription and NotificationPreferences models with migration - VAPID key generation management command and pywebpush integration - Service worker (sw.js) and client subscribe/unsubscribe flow - Notification preferences UI on the security page - Server-side dispatch on key tournament events (match start, results, tournament created, admin announcements) - E2E tests covering subscription flow and preferences
Co-authored-by: Yunaido <33319800+Yunaido@users.noreply.github.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 32153565 | Triggered | Vapid Key | 4a86ac4 | compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Contributor
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Summary
Implements a notification service so users can receive real-time updates about tournament events on desktop browsers and mobile devices, even when the app isn't focused.
What's included
accounts/notifications.py; VAPID keys generated by thegenerate_vapid_keysmanagement command.static/js/sw.js) — handlespushevents and notification clicks (deep-links to the relevant page).static/js/push-notifications.js) — registers the SW, requests permission, and stores the subscription.PushSubscriptionandNotificationPreferences(per-user opt-in per event type).notification_preferences.htmltemplate.tournaments/views.pyandtournaments/pairing.py).e2e/tests/notifications.spec.tscovers the subscription flow and preference toggles;security.spec.tsupdated for the new section.Issue checklist