Improve flaky tests#477
Merged
Merged
Conversation
We had a "Gave up after 9 successful property evaluations" failure on GitHub actions, so a factor 20 seems to be _just_ a bit too restrictive. Why discard property evaluations here? The purpose of these tests are to verify that whenever `finishAssertion` succeeds, the `AssertionResult` is internally consistent and consistent with the request `username` and `userHandle` (if any). For that sake, it is relevant to have the generators be more generous with generating combinations that _shouldn't_ succeed `finishAssertion` but do anyway, such as the edge case that was the cause of YSA-2026-02.
This prevents the unit test XML reports from containing large stdout logs which are not used for anything but crash the default settings of EnricoMi/publish-unit-test-result-action@v2 . This was originally done in commit cdf9513 and then undone for no apparent reason in efa4b00. The tests added in efa4b00 do not use any of the features of `slf4j-test`; it appears the dependency was re-added solely for capturing log output.
fdennis
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump maxDiscardedFactor in RelyingParty[V2]AssertionSpec
We had a "Gave up after 9 successful property evaluations" failure on GitHub actions, so a factor 20 seems to be just a bit too restrictive.
Drop slf4j-test from webauthn-server-attestation test dependencies
This was originally done in commit cdf9513 and then undone for no apparent reason in efa4b00. The tests added in efa4b00 do not use any of the features of
slf4j-test; it appears the dependency was re-added solely for capturing log output.