Tour: descend to the last mood (all formats) + remove stage halos#33
Merged
Conversation
…os removed
User report : the Pick-a-mood tour step never reached the bottom of
the grid, on any viewport. TWO root causes :
1. The step's end anchor ('title still visible', sectionTop+40)
always won over 'show all content' for the tall grid — rows 2-3
were never shown. The descent now ends with the LAST grid cell at
~92% of the viewport, measured at run time, so the single-column
mobile grid simply yields a longer, equally smooth glide.
2. Round-16 regression : the tour's tween callbacks called
window.scrollTo(0, y) per frame — with the CSS
html{scroll-behavior:smooth} added in round 16, EVERY tween frame
became its own eased glide : the tween trailed its target and the
descent stopped short. All 3 tween callbacks now pass
behavior:'instant' (the tween is the easing), same fix as
useDemoTour.scrollTo got in round 16.
Verified by driving the real tour to step 5/10 on desktop 2K and
390px mobile : lastCellFullyVisible=true on both (bottom at 92% vh).
Also : the orange halo behind both resize/drag stages removed
(user request), screenshot-verified.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two root causes for the user-reported tour bug: the end-anchor always capped the descent at row 1, and a round-16 regression made every tween frame fight the CSS smooth-scroll (descent stopped short). Now ends with the last cell at 92% vh, measured at runtime (mobile's single column just glides longer). Verified by driving the real tour to step 5/10 at 2560 and 390px:
lastCellFullyVisible=trueboth. Orange stage halos removed on request.🤖 Generated with Claude Code