Skip to content

Fix Windows installer temporary cleanup#64

Open
giri256 wants to merge 1 commit into
Xndr2:mainfrom
giri256:fix/issue-55-temp-cleanup
Open

Fix Windows installer temporary cleanup#64
giri256 wants to merge 1 commit into
Xndr2:mainfrom
giri256:fix/issue-55-temp-cleanup

Conversation

@giri256

@giri256 giri256 commented Jul 21, 2026

Copy link
Copy Markdown

Description

Prevents Windows installer temporary-file cleanup from failing an otherwise successful installation.

  • Adds one best-effort cleanup helper that uses -LiteralPath for exact path handling.
  • Skips missing or invalid paths safely.
  • Converts cleanup failures into warnings instead of terminating the installer.
  • Uses the helper for the Spicetify bootstrap archive and the Listening Stats archive/extraction directory.

Type of Change

  • Bug fix
  • New feature
  • Enhancement / improvement
  • Documentation
  • Refactor (no functional change)
  • Other

Related Issue

Fixes #55

How to Test

  1. Parse install.ps1 with Windows PowerShell 5.1.
  2. Invoke the cleanup helper with file and directory paths containing spaces and [] wildcard characters.
  3. Verify both paths are removed and a missing path does not throw.
  4. Run the repository checks listed below.

Verification

  • Windows PowerShell 5.1 parser and focused cleanup regression: passed.
  • corepack pnpm@9.15.9 lint: passed with three pre-existing CSS specificity warnings.
  • corepack pnpm@9.15.9 typecheck: passed.
  • TZ=UTC corepack pnpm@9.15.9 exec vitest run --reporter=dot: 79 test files and 1,222 tests passed.
  • NODE_ENV=production corepack pnpm@9.15.9 build: passed.
  • git diff --check: passed.

Checklist

  • Tested locally with a production build (no errors)
  • Tested by reinstalling into Spotify/Spicetify (not run because this cleanup-only patch would mutate the local application installation)
  • Provider behavior is unaffected
  • No sensitive data included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Install / Update Script Failing

1 participant