feat: ShareModal Toggle, caption controls, and zero-play fallbacks#52
Merged
Conversation
Replace raw checkbox with Spicetify Toggle component. Add showUsername/showPeriodLabel toggle controls. Export ShareVariant type and add initialVariant prop. Add showShareCaption preference. Fix zero-play edge cases across all canvas renderers so share cards render gracefully when there is no data. Fix preview container sizing for consistent modal layout.
Death-Watcher
force-pushed
the
pr/share-modal-controls
branch
2 times, most recently
from
8b1f51b to
1bd508f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three UX improvements to the share modal:
<input type="checkbox">for "Follow theme" with Spicetify's<Toggle>component for a native look.showShareCaptionpreference (defaulttrue) to persist the choice.height: min(58vh, 640px)withmin-height: 320pxfor consistent layout.Type of Change
How to Test
npm install && npm run buildChecklist
npm run build(no errors)npx vitest run)npx tsc --noEmit)Files Changed
src/app/components/ShareModal.tsx— Toggle, caption controls, zero-play canvas fixes, preview sizingsrc/app/preferences.ts—showShareCaptionpreferencesrc/test/share-modal.test.tsx— Toggle selector updatesrc/app/styles.css— preview container sizing