fix: hide duration badge and 0-plays label for zero-count items in TopLists#49
Open
Death-Watcher wants to merge 5 commits into
Open
fix: hide duration badge and 0-plays label for zero-count items in TopLists#49Death-Watcher wants to merge 5 commits into
Death-Watcher wants to merge 5 commits into
Conversation
…pLists When a track/artist/album has 0 plays, the duration badge and play-count label are now hidden instead of showing unhelpful "<1 min" or "0 plays" text.
Death-Watcher
force-pushed
the
pr/toplists-display
branch
2 times, most recently
from
109ae32 to
2d0acb2
Compare
Xndr2
requested changes
May 19, 2026
Xndr2
left a comment
Xndr2
left a comment
Owner
There was a problem hiding this comment.
Please bring the code up to date with main
This has merge conflicts
Contributor
Author
Hope it is fixed now... im sorry for your extra work |
Xndr2
requested changes
May 22, 2026
Xndr2
left a comment
Xndr2
left a comment
Owner
There was a problem hiding this comment.
@Death-Watcher This pr contains the dragging and dropping code from a previous pr.
Please delete this code, or make a separate pr for this. But I've said before I wont implement the "in dashboard reordening". Looking from a UX perspective it just doesnt work. Nice implementation tho
Owner
Death-Watcher
force-pushed
the
pr/toplists-display
branch
from
e013d55 to
a18b063
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean up the TopLists display when tracks, artists, or albums have 0 plays or 0 duration:
count === 0(no point showing "<1 min" for an unplayed track).count === 0; genre tag remains clickable.count === 0; artist name remains visible.The rows themselves stay visible so the user doesn't lose context — only the unhelpful numbers are suppressed.
Type of Change
How to Test
npm install && npm run buildcount === 0show no duration badgecount === 0show no "0 plays" textcount === 0show no "· 0 plays" textChecklist
npm run build(no errors)npx vitest run)npx tsc --noEmit)Files Changed
src/app/components/TopLists.tsx— conditional rendering of duration badge and play-count labels