fix: remove server.url/host/port consistency validator#343
Open
evagundan wants to merge 2 commits into
Open
Conversation
The _validate_server_url_host_port validator assumes server.url matches server.host:server.port, which breaks deployments where the external URL differs from the local bind address (e.g. behind a reverse proxy or when server.url points to a different host/port for agent webhook callbacks). Remove this validator to allow flexible server.url configuration.
|
|
|
👋 感谢提交 PR @evagundan!维护者会尽快 review。 提交前请确认:
|
Add a new Rules tab to the sidebar that displays configured automation rules with enable/disable toggles and manual trigger buttons. Changes: - Add Rule type definitions to types.ts - Add rule API functions (list, toggle, trigger) to real.ts and index.ts - Create RuleListPanel component with rule cards showing: - Rule name with tag badge - Mode badge (event/state) - Condition query text - Duration/ratio info - Toggle switch and trigger button - Add rules tab to Sidebar navigation - Add i18n translations for zh and en - Wire rules panel into App.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_validate_server_url_host_portmodel validator fromMilocoSettingsMotivation
The validator assumes
server.urlmatchesserver.host:server.port, which breaks deployments where the external URL differs from the local bind address:server.urlpoints to the public URL (e.g.https://miloco.example.com) whileserver.hostis127.0.0.1server.urlmay point to a different host/port for agent webhook callbacksThe validator only emits a warning (doesn't block startup), but the warning is misleading in these scenarios — the configuration is intentional, not a mistake.
Changes
backend/miloco/src/miloco/config/settings.py: Remove_validate_server_url_host_portmethod and its comment block (49 lines removed)Testing
server.urlandserver.host:server.port