Repository navigation
YARG y Clone Hero ignoran assets aarch64/arm64 - #75
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Xalcker
added this pull request to stack #76
October 3, 2026 20:28
…arga El regex por defecto (linux.*(x86_64|x64|64)...) tambien coincide con nombres como Linux-aarch64.zip por el "64" suelto, y el respaldo linux*.zip tomaba el primer asset. Se descartan los assets ARM antes de aplicar el regex y el respaldo, en el instalador y en los updaters. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Xalcker
force-pushed
the
fix/excluir-assets-arm
branch
from
October 3, 2026 20:29
2af4097 to
785c40d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
El regex por defecto de YARG, `linux.(x86_64|x64|64)..zip`, también coincide con `Linux-aarch64.zip` por el `64` suelto, y el respaldo `linux.*.zip` toma el primer asset. Si un release publicara ARM antes que x86_64, se instalaría el binario equivocado.
Cambio
Se descartan los assets `aarch64` / `arm64` antes de aplicar el regex y el respaldo, en el instalador y en los updaters de YARG y Clone Hero. Incluye 3 pruebas nuevas en `tests/test_updaters.bats`.
Pruebas
Suite completa en WSL: 437 pruebas, 0 fallos.
PR apilado sobre #74 (usa su archivo de pruebas); GitHub lo retargetea a `main` cuando #74 se mergee.
🤖 Generated with Claude Code