Repository navigation
refactor: unifica wrapper, menu y servicio de Cage (#28) - #69
Merged
Merged
Conversation
…me.sh (#28) YARG, Clone Hero y RPCS3 compartian tres copias casi identicas del prologo del wrapper, el menu de mantenimiento y cage-kiosk.service. Ahora viven en kiosk_wrapper_prelude, install_kiosk_menu e install_cage_service, y cada app solo aporta su bloque especifico. Se agregan pruebas de comportamiento del wrapper, el menu y la unidad generados. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cierra #28.
Mueve el prologo del wrapper (entorno, DBus, PipeWire), el menu de mantenimiento y
cage-kiosk.servicealib/kiosk_runtime.sh; YARG, Clone Hero y RPCS3 solo conservan su bloque especifico (-1000 lineas duplicadas).Cambios de comportamiento menores: el wrapper de YARG fija
HOME; el menu de RPCS3 gana el respaldo denmclipara WiFi; todos muestran el aviso si faltadbus-run-session.Pruebas: nuevo
tests/test_kiosk_runtime.bats(14 casos: prologo, orden de PipeWire, menu y sus opciones, unidad systemd). En la suite completa fallan 4 casos; 3 ya fallaban en main en esta maquina (Windows), y el cuarto (README) ya esta corregido en el PR. No se pudo validar en el kiosko real.🤖 Generated with Claude Code