Upgrade Aptos to latest Aptos Wallet Adapter version#76
Open
0xmaayan wants to merge 1 commit into
Open
Conversation
|
XLabs/wallet-aggregator-sdk #76 Change Summary:
Risk Score: 3
Potential Vulnerability: Code Smell: // Removed multiple wallet imports which suggests previous code might have been including non-functional or deprecated adapters
// Previous implementation was including wallets that were commented out or not working
Debug Log: Unintended Consequences: async connect(): Promise<string[]> {
await this.walletCore.connect(this.selectedAptosWallet.name);
// set account
this.account = this.walletCore.account;
// Set address
this.address = this.account?.address.toString();
this.walletCore.on(
"accountChange",
async (accountInfo: AccountInfo | null) => {
this.account = accountInfo;
this.address = accountInfo?.address.toString();
}
);
// ... rest of the method
}
Additional Observation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aptos Wallet Adapter has been major upgraded to support only wallets that follow the official Apos wallet standard, see aptos-labs/aptos-wallet-adapter#464
This PR updates the
@xlabs-libs/wallet-aggregator-aptosto be up to date with the latest Aptos wallet adapter, as well as bumps other Aptos dependencies versions.This is important because
You can see latest version deployed here https://aptos-labs.github.io/aptos-wallet-adapter/
Note: looks like the
@xlabs-libs/wallet-aggregator-aptosdoes not follow semver? I'd assume this type of change requires a major bump, but will be happy to bump to whatever you think makes sense.Also, if you have a test plan I can follow, I'd be happy to