Fix Codex JSON detection for absolute binary path#18
Open
yuejunzhao wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Codex JSON provider detection when the Codex binary is configured with an absolute path.
Previously,
_provider_uses_codex_json()only returned true whenprovider["bin"]was exactly"codex". If the provider used an absolute path such as/home/user/.nvm/versions/node/v22.22.2/bin/codex, Codex JSONL output was not recognised as Codex output.This change compares
Path(bin).name == "codex", so both short command names and absolute Codex binary paths are supported.Tested locally with an absolute Codex binary path and confirmed:
_provider_uses_codex_json()returns truellm_get_json()correctly extracts the assistant message text from Codex JSONL outputoutput/final_video.mp4