60116 deprecated function#5802
Conversation
Extended the PHPUnit test suite for the 'doingItWrong' function in WordPress. Added more comprehensive test cases, including the setup phase and validation for the error notice. These improvements enhance code quality by ensuring that the function behaves as expected under varying conditions.
Removed unnecessary actions in the 'doingItWrong' PHPUnit test setup. The setup is simplified for a cleaner and more focused testing of the 'doingItWrong' function. This streamlining allows for accurate and effective evaluation of the function's overall performance and expected behavior.
Renamed 'doingItWrong' PHPUnit test file and class to 'deprecatedHook' to match its function testing. Adjusted all method names, action hooks, comments, and tested functionalities inside test methods to focus on the '__deprecated_hook' function. This is a pivotal change for a more precise assessment of '__deprecated_hook' function's behavior and performance under varying scenarios.
… 'deprecatedArgument' to represent the actual function being tested. All related method names, action hooks, comments, and functionality within the test methods have been adjusted to focus on the '_deprecated_argument' function. This change allows for a more accurate evaluation of the '_deprecated_argument' function's behavior and performance.
…ile' to better reflect the functionality being tested. All relevant method names, hooks, comments, and tests have been updated accordingly. This refactoring allows more accurate and specific testing of the '_deprecated_file' function.
A typo was detected and fixed in the phpunit test file 'deprecatedClass.php'. The underscore separating '_deprecated_class' and 'function' in the method comments section was missing, which could lead to readability issues.
…om `deprecatedClass` to `deprecatedFunction`. All associated actions, filters, and method names within the test have been updated to match this change. This ensures our tests now correctly apply to deprecated functions instead of deprecated classes.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
1 participant
Trac ticket: https://core.trac.wordpress.org/ticket/60116