added test for get_num_queries and wp_get_nocache_headers#1930
added test for get_num_queries and wp_get_nocache_headers#1930pbearne wants to merge 21 commits into
Conversation
costdev
left a comment
There was a problem hiding this comment.
Thanks for this PR to improve the test suite @pbearne! Nice work!
This review contains suggestions to:
- make the tests, filenames and classnames consistent with others in the test suite.
- make the assertions stricter.
- make clear which assertion fails, and why, when multiple assertions exist.
- make a clear distinction between what is being tested.
- make tests more performant.
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
|
@pbearne @costdev I've pushed up several changes
|
costdev
left a comment
There was a problem hiding this comment.
Thanks @peterwilsoncc!
A couple of changes to docblock descriptions for consistency and so that third-person singular verbs are used.
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Trac ticket: