Skip to content

KSES: Allow CSS anchor positioning in safecss_filter_attr() #12337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhrupo wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

KSES: Allow CSS anchor positioning in safecss_filter_attr() #12337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/wp-includes/kses.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2553,6 +2553,8 @@ function kses_init() {
* @since 6.5.0 Added support for `background-repeat`.
* @since 6.6.0 Added support for `grid-column`, `grid-row`, and `container-type`.
* @since 6.9.0 Added support for `white-space`.
* @since 7.1.0 Added support for CSS anchor positioning properties and the
* `anchor()` and `anchor-size()` functions.
*
* @param string $css A string of CSS rules, decoded from an HTML `style` attribute.
* @param string $deprecated Not used.
Expand Down Expand Up @@ -2734,6 +2736,16 @@ function safecss_filter_attr( $css, $deprecated = '' ) {
'aspect-ratio',
'container-type',

// CSS anchor positioning.
'anchor-name',
'anchor-scope',
'position-anchor',
'position-area',
'position-try',
'position-try-fallbacks',
'position-try-order',
'position-visibility',

'fill',
'fill-opacity',
'fill-rule',
Expand Down Expand Up @@ -2913,7 +2925,7 @@ function safecss_filter_attr( $css, $deprecated = '' ) {
* Nested functions and parentheses are also removed, so long as the parentheses are balanced.
*/
$css_test_string = preg_replace(
'/\b(?:var|calc|min|max|minmax|clamp|repeat)(\((?:[^()]|(?1))*\))/',
'/\b(?:var|calc|min|max|minmax|clamp|repeat|anchor-size|anchor)(\((?:[^()]|(?1))*\))/',
'',
$css_test_string
);
Expand Down
26 changes: 26 additions & 0 deletions tests/phpunit/tests/kses.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,6 +1001,7 @@ public function test_wp_kses_attr_no_attributes_allowed_with_false() {
* @ticket 60132
* @ticket 64414
* @ticket 65457
* @ticket 64972
*
* @dataProvider data_safecss_filter_attr
*
Expand Down Expand Up @@ -1511,6 +1512,31 @@ public function data_safecss_filter_attr() {
'css' => 'text-anchor: middle',
'expected' => 'text-anchor: middle',
),
// CSS anchor positioning properties are allowed.
array(
'css' => 'anchor-name: --tooltip;anchor-scope: all;position-anchor: --tooltip;position-area: top;position-try: flip-block;position-try-fallbacks: --fallback;position-try-order: most-height;position-visibility: anchors-visible',
'expected' => 'anchor-name: --tooltip;anchor-scope: all;position-anchor: --tooltip;position-area: top;position-try: flip-block;position-try-fallbacks: --fallback;position-try-order: most-height;position-visibility: anchors-visible',
),
// The `anchor()` function is allowed in inset properties.
array(
'css' => 'top: anchor(--tooltip bottom)',
'expected' => 'top: anchor(--tooltip bottom)',
),
// The `anchor-size()` function is allowed in sizing properties.
array(
'css' => 'width: anchor-size(--tooltip width)',
'expected' => 'width: anchor-size(--tooltip width)',
),
// The `anchor-size()` function is allowed when nested in another function.
array(
'css' => 'margin-left: calc(anchor-size(width) / 2)',
'expected' => 'margin-left: calc(anchor-size(width) / 2)',
),
// Allowing `anchor()` must not allow other, unknown functions.
array(
'css' => 'width: expression(alert(1))',
'expected' => '',
),
);
}

Expand Down
Loading