AI Client: fix sendRequestWithOptions error message inconsistency and add missing tests#12108
Conversation
… add missing tests sendRequestWithOptions omitted the HTTP method from its NetworkException message, while sendRequest included it. Both paths now produce the same three-argument format so error messages carry consistent diagnostic context. Two new tests are added: - Verifies the method, URL, and underlying error appear in the exception message thrown by sendRequestWithOptions. - Verifies that generate_result() returns a WP_Error carrying the correct "AI features are not supported" message when wp_supports_ai() is false, covering a code path that was previously untested. https://core.trac.wordpress.org/ticket/64591
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| @@ -2533,49 +2533,48 @@ public function test_is_supported_returns_false_when_ai_not_supported() { | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
This test landed as part of https://core.trac.wordpress.org/ticket/65422.
|
@sagarsdeshmukh – I updated the description and removed the reference to https://core.trac.wordpress.org/ticket/65422. It triggered the automation and closed this PR when another ticket was closed. Can you refresh this PR to exclude the test that was merged with that ticket? |
2 participants
Summary
WP_AI_Client_HTTP_Client::sendRequestWithOptions()omitted the HTTP method from itsNetworkExceptionmessage, whilesendRequest()included it. Both now use the same three-argument format so error output carries consistent diagnostic context (method + URL + underlying error).sendRequestWithOptions.WP_AI_Client_Prompt_Builder::generate_result()whenwp_supports_ai()returns false - this code path produced a distinct error message ("AI features are not supported in this environment.") that was untested.Changes
src/wp-includes/ai-client/adapters/class-wp-ai-client-http-client.phptests/phpunit/tests/ai-client/wpAiClientHttpClient.phptests/phpunit/tests/ai-client/wpAiClientPromptBuilder.phpTest coverage
Run:
npm run test:php -- --group=ai-clienthttps://core.trac.wordpress.org/ticket/65421