Add pull-files and pull-db commands#279
Draft
adamziel wants to merge 13 commits into
Draft
Conversation
Contributor
Pull pipeline performance —
|
| Stage | Wall time | Resume attempts | Status | Details |
|---|---|---|---|---|
playground-sqlite-db-download |
7.45 s | 1 | ✓ | condition=db-download in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected |
playground-sqlite-db-apply |
2.82 s | 1 | ✓ | condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified |
| Total | 10.27 s |
Numbers carry runner noise; treat single-run deltas as directional, not authoritative.
📈 Trunk performance history — commit-by-commit timeline.
ebc0676 to
2aa5410
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two higher-level commands:
pull-files, which runs the same retrying file-download stage used bypullpull-db, which runs the same retrying database-download stage used bypullThe full
pullpipeline now delegates its file and database stages through those higher-level methods instead of calling the lower-levelfiles-pull/db-pullhandlers directly. Command help and option grouping include the new commands.Tests
PATH="$PWD/.context/test-bin:$PATH" php -n vendor/bin/phpunit --configuration tests/phpunit.xml tests/Import/PullFilterOptionTest.php tests/Import/PullStartModeTest.php tests/Import/LegacyCommandAliasTest.php tests/Import/OnlyCliParseTest.php --testdox --colors=neverphp -n -l packages/reprint-importer/src/import.phpphp -n -l packages/reprint-importer/src/lib/pull/class-pull.phpphp -n -l tests/Import/PullFilterOptionTest.phpPATH="$PWD/.context/test-bin:$PATH" php -n /Users/cloudnik/.local/bin/composer analyzeNotes
composer testis not clean in this workspace because the MySQL-backed tests cannot connect to127.0.0.1(SQLSTATE[HY000] [2002] Connection refused).composer lint:phpstill reports existing PHPCS issues across the repository unrelated to this change.