Icons: Fix viewBox casing assertion in wp_get_icon test for older WP#79576
Merged
Conversation
The test_wp_get_icon_default_attributes test asserts a lowercase `viewbox` attribute, which only holds on WP 7.0+ where wp_kses() parses attributes via the HTML API and lowercases names. Older WP versions preserve the original `viewBox` casing, so the test failed there. Assert case-insensitively to support both. Co-Authored-By: Claude <noreply@anthropic.com>
t-hamano
added
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SainathPoojary
pushed a commit
to SainathPoojary/gutenberg
that referenced
this pull request
Jun 29, 2026
…ordPress#79576) The test_wp_get_icon_default_attributes test asserts a lowercase `viewbox` attribute, which only holds on WP 7.0+ where wp_kses() parses attributes via the HTML API and lowercases names. Older WP versions preserve the original `viewBox` casing, so the test failed there. Assert case-insensitively to support both. Co-authored-by: t-hamano <wildworks@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #78332
What?
Fixes the
test_wp_get_icon_default_attributesunit test failing on the previous major WordPress version.https://github.com/WordPress/gutenberg/actions/runs/28224303166/job/83612783910
Why?
The test asserts a lowercase
viewboxattribute. This only holds on WP 7.0+, wherewp_kses()parses attributes via the HTML API and lowercases attribute names (viewBox→viewbox). The previous major WP version preserves the originalviewBoxcasing, so the assertion failed there.How?
Asserts the
viewBoxattribute case-insensitively so the test passes on both the latest and previous WordPress versions.Testing Instructions
This version-dependent failure can't be reproduced in this PR's CI against trunk. Once merged, the unit test job against the previous major WordPress version should pass, confirming the fix.
Use of AI Tools
Authored with assistance from Claude Code. All changes were reviewed by the author.