Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

LA-224 AI fitting - step 12 - bugfix for tagging threaded text frames#61

Open
Edwin-van-der-Klaauw wants to merge 1 commit into
LA-224_AI-fitting11-spellingfrom
LA-224_AI-fitting12-threaded-bugfix
Open

LA-224 AI fitting - step 12 - bugfix for tagging threaded text frames#61
Edwin-van-der-Klaauw wants to merge 1 commit into
LA-224_AI-fitting11-spellingfrom
LA-224_AI-fitting12-threaded-bugfix

Conversation

@Edwin-van-der-Klaauw

Copy link
Copy Markdown
Contributor

When tagging, having selected only the 2nd frame of threaded frames, the InDesign Article creation went wrong; Always a new InDesign Article got created (bug#1) and the 2nd frame got added (bug#2). Same problem when having any other succeeding frame(s) selected, except for the first frame of the thread.

  • Bug#1: It should not create an InDesign Article when the frame already belongs one. In that case, it should rename the article.
  • Bug#2: It should always add the first text frame of the threaded frames to the article, and not any of its succeeding frames.

Note that this was fixed as a preparation step for the AI fitting feature. For this feature, the frame selection logic is shared with the tagging- and export features. So when you'd select a 2nd frame of a thread, and click the Fit Article with AI menu item, it needs to resolve the correct InDesign Articles, indirectly being "selected".

…hreaded frames, the InDesign Article creation went wrong; Always a new InDesign Article got created (bug#1) and the 2nd frame got added (bug#2). Same problem when having any other succeeding frame(s) selected, except for the first frame of the thread. Bug#1: It should not create an InDesign Article when the frame already belongs one. In that case, it should rename the article. Bug#2: It should always add the first text frame of the threaded frames to the article, and not any of its succeeding frames.

@tpiwoodwing tpiwoodwing left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants