Add CI rule-linting workflow - #243
Merged
alexkornitzer merged 1 commit intoSep 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #241 per review — this is the GitHub Actions half: the new linting workflow, plus the
v2.ymlcleanup requested in that PR's open questions.Changes
1.
.github/workflows/lint-rules.yml— runs on PRs touchingrules/,src/or the cargo manifests (and on push tomaster). It builds chainsaw from the PR's own source rather than downloading a release, so a rule that depends on a schema change in the same PR is validated against that change. UsesSwatinem/rust-cache, so only the first run pays the full build. Depends on #242 (or another lint fix) landing first for the check to actually gate on rule failures — until then it builds and lints butchainsaw lintstill exits 0 on failure.2.
v2.yml— replaced the archivedactions-rs/toolchain@v1withdtolnay/rust-toolchain@stableacross all 5 jobs, per the open question in #241. Behavior is equivalent:profile: minimal/override: true/default: trueare no-ops fordtolnay/rust-toolchain(it always installs minimal and sets itself as the active toolchain), andtarget/targetsmap directly.v1.ymlis untouched — out of scope per the original ask.Verification
yamllinton both files: no new warnings/errors vs. currentmaster(pre-existing line-length debt inv2.ymlrun:lines is unchanged, not introduced here).