Feature/popular movies security#17
Open
AhmedSaber0 wants to merge 21 commits into
Open
Conversation
… datasource-model and mapper - Create remote-model module with MovieResponse POJO class - Create local-model module with MovieLocal POJO class "which is room entity class". - Create datasource-model module with MovieDataSource POJO class - Create mapper module that contains mapper classes which maps datasource models to entity models.
- Create remote module for initializing network library "which is retrofit". - Create local module for initializing local library "which is room". - Create MovieDao for CRUD operations and MovieDatabase for room database integration.
…ures modules inside it. - Create popular-movies module inside features package. - Create PopularMovieRepo class inside repository package that handles offline first architecture. - Create PopularMovieUseCase class inside usecase package that deals with PopularMovieRepo class - Create PopularMovieService interface that contains retrofit functions
… for each feature. - Create popular-movie-presentation module inside presentation folder. - Create PopularMovieVM inside vm folder. - Create PopularFragment that will has One-To-One relationship with PopularMovieVM. - Create PopularMovieAdapter that handles the list of the popular movie.
…movie/MoviesServiceFactory.kt Co-Authored-By: Muhammad <muhammadyoussef.27@gmail.com>
remove local, remote and data source dependency from gradle
…vie/DataConverter.kt use object insted of class Co-Authored-By: Ahmed Adel <ahmed.adel.said@gmail.com>
…ture/popular-movies # Conflicts: # datasource/remote/src/main/AndroidManifest.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change log
Add a list of the files of the functionality that was changed in this PR
file.javafile2.javafile3.javaTested scenarios
Add a check list of the test scenarios that you've covered for this PR
Qc notes
Notes to help the Qc team tackle this pull request right
Links