Rework PDF export: book typography, theme colors, own markdown renderer#585
Merged
Conversation
Better formatting now!
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 143 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #585 +/- ##
===========================================
+ Coverage 52.78% 52.84% +0.05%
===========================================
Files 440 441 +1
Lines 18491 18803 +312
Branches 2679 2794 +115
===========================================
+ Hits 9761 9936 +175
- Misses 7954 8041 +87
- Partials 776 826 +50
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
pdfkmp-markdownmodule with our own markdown renderer (PdfProseMarkdown.kt) built on the same intellij-markdown engine the EPUB export uses (GFM flavour), giving the PDF export book typography that pdfkmp's markdown module could not express:firstLineIndentif upstream grows one).Also fixes for free, by virtue of the spec-compliant parser: backslash-escape handling (the
stripBackslashEscapesworkaround is gone) and PDF/EPUB now parse markdown with the same engine so the two exports cannot disagree on structure.Testing
PdfProseMarkdownTest), plus the existing export integration tests.PdfProseVisualCheck(env-gated, skipped in CI) renders a sample PDF for eyeballing typography changes; output verified visually.🤖 Generated with Claude Code