Instant loot framework#583
Merged
Merged
Conversation
feat: added HealReward and AbilityResourceReward feat: added RewardInstantLootFunction and WrappingConditionalLootFunction change: potions in wooden chests are now instant loot Any item with InstantLoot component will be instantly consumed when picked up or interacted with in inventory
immortius
approved these changes
Feb 21, 2026
immortius
left a comment
immortius
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Might want to add InstantLoot::tryConsume to some of the methods in ItemStackHandlerUtil which are used when players close a temporary inventory screen (like the reward screen) so they don't end up with InstantLoot items in their inventory from that mechanism.
refactor: simplified addOrGiveToPlayerOrDrop, changed ServerPlayer parameter of placeInPlayerInventoryOrDrop to Player
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds instant loot Data Component.
Any item with this data component will be consumed instantly when:
Healing potions have been changed to an instant loot.
Closes #581
Future work:
Apply in AOE. (or cast an ability when instant loot is collected)
Add some new items with custom models.
Could be used for an alternate Item Objective.