Changed anomalies to always give a reward#555
Conversation
immortius
left a comment
immortius
left a comment
There was a problem hiding this comment.
The anomaly reward data fix is good, although there's still only a chance of getting an item. I was wondering if there is a reason that strength has been replaced with absorption?
No, there isn't I was just trying out different effects and left that instead of strength, I will change it back to strength. By the way, in #529 I mentioned adding a This PR should wait for #551. Once that one is merged, I can update each anomaly theme reward to give themed rewards, such as a skill thread, some essences from the loot table, and another theme-related item. |
…back to "strength" in ender_pearl.json
Attack8
changed the title
That looks fine. |
|
@family2015 With #551 merged is there anything more you need to move this forward? |
Didn't notice it was merged, I will start to work on it |
…d-effect-every-completion # Conflicts: # src/main/resources/data/wotr/worldgen/processor_list/anomaly_theme_default.json
|
Right now my game crashes when I try to create or join a world, I not sure on what is wrong |
|
[wotr:anomaly_theme_deepfrost, wotr:anomaly_theme_jungle, wotr:anomaly_theme_meadow] |
|
You also have a ton of missing models for motr. Idk if that is bad, or just log |
…d-effect-every-completion
| "rewards": { | ||
| "wotr:strength5": 10.0, | ||
| "wotr:ender_pearl": 10.0 | ||
| "wotr:buzzy_bees_speed": 10.0, |
There was a problem hiding this comment.
The setup of the anomaly rewards is a bit awkward like this, having both the effect and loot table tied together and thus needing two reward files for each theme, one for each effect. We probably should rework the anomaly reward setup in the future to allow for a cleaner way of specifying - "reward an item from this loot table, and one of these effects". Possibly a list of FastWeightedList?
Future thoughts
Attack8
deleted the
family2015/529-set-anomalies-to-give-loot-and-effect-every-completion
branch
5 participants
This PR aims to do the next things: