Repository navigation
Conversation
A blocked country written as cu did not match MaxMind's CU, so the request was allowed. Subdivision codes already ignore ASCII case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Country blocks compared the configured code to MaxMind's ISO code with
==. MaxMind returns uppercase codes (CU). A list entry ofcudid not match, so the request was allowed. Subdivision codes already ignore ASCII case. The country check now does too.The visitor does not choose the block list. A lowercase entry in the operator's config fails open and serves traffic from a country the operator meant to block.
No existing issue.
How Has This Been Tested?
cargo test -p geoip --features middleware test_country_blockedThe new test configures
cuagainst a resolver that returnsCUand expects 401. Reverting the comparison makes that test return 200.cargo +nightly-2026-02-11 fmt --all -- --checkpassed.cargo +nightly-2026-02-11 clippy -p geoip --all-features --all-targets -- -D warningspassed.Due Diligence