feat(api): add DiscogsReleaseMetadata.not_found tombstone marker (1.12.0)#174
Merged
Merged
Conversation
…2.0) `not_found = true` means LML hit Discogs and got a 404 for this release id, so the row is a tombstone — `title = ""` and `artist = ""` are identifier sentinels rather than real values. LML's public boundary already translates the tombstone back to `None` for direct callers; the flag is exposed in the schema for future cross-service readers (BS, dj-site, iOS) so they can read the cache row directly without re-deriving the 404 state. Companion to the discogs-etl `release.not_found` migration and LML's `_api_fetch` 404-discrimination work in WXYC/library-metadata-lookup#510. Defaulting to `false` keeps the change additive: every existing caller that doesn't read the flag continues to behave exactly as it did pre-1.12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
not_found: boolean (default false)toDiscogsReleaseMetadata.truemeans LML hit Discogs and got a 404 for this release id, so the row is a tombstone —title = ""andartist = ""are identifier sentinels rather than real values.Nonefor direct callers (theT | Nonecontract is unchanged for the LML API surface); this flag is exposed in the schema for future cross-service readers (Backend-Service, dj-site, iOS) so they can read the cache row directly without re-deriving the 404 state.info.version1.11.0 → 1.12.0. Additive only — every existing consumer that doesn't read the flag continues to behave exactly as it did pre-1.12.Land order
After
WXYC/discogs-etlships the alembic migration addingrelease.not_foundto the cache schema. ThenWXYC/library-metadata-lookup#510pins this release and regeneratesgenerated/api_models.py.Test plan
npm run test— 460 passed (no schema-shape contract regressions).npm run lint— clean.npm run check:breaking— no breaking changes.npm run generate:typescriptsucceeds.Related
release.not_foundschema migration ships in WXYC/discogs-etl.