ci: add code-audit PR-comment workflow#1423
Open
jakebromberg wants to merge 2 commits into
Open
Conversation
Wires Backend-Service into the code-audit-pipeline reusable workflow at pr-comment-reusable.yml@v0.3.2. Every PR to main gets a sticky structural- impact comment (duplicate clusters, cross-package shadows, near-duplicates touched by the diff). Fail-quiet so the audit never blocks a PR. Also gitignores .audit/ — the pipeline's runner-temp output should never end up tracked. Pinned to v0.3.2 (latest stable); bump to @v1 once the pipeline cuts v1. Closes #1422
v0.3.3 fixes the cross-repo path-resolution bug in pr-comment-reusable.yml that 404'd on the audit-core action lookup when invoked from a sibling consumer repo. See jakebromberg/code-audit-pipeline#273.
shape-sig-frequencyshape_sig values by frequency — discovery helper for migration-progress. 20 row(s), shape: metric. shape-sig-frequency:querychunks?:array<string-|-{-value?:-string-|-string[]-}>|sql?:string-|-string[]
shape-sig-frequency:repo:string|run_id:string|tool:string
shape-sig-frequency:repo:string|runid?:string|tool:string
shape-sig-frequency:totals:totals
shape-sig-frequency:album:string-|-null|artist:string|name:string|track:string-|-null
shape-sig-frequency:album_title:string|artist_name:string|id:number
shape-sig-frequency:artists:string[]|duration:string-|-null|position:string|title:string
shape-sig-frequency:querychunks?:array<string-|-{-value?:-string-|-string[];-raw?:-string-}>|raw?:string|sql?:string-|-string[]
shape-sig-frequency:setattribute:typeof-mockspansetattribute|setattributes:typeof-mockspansetattributes
shape-sig-frequency:album_id:number-|-null|album_title:string-|-null|artist_name:string|id:number|track_title:string-|-null
shape-sig-frequency:album_id:number|album_title:string|artist_name:string
shape-sig-frequency:album_title:string-|-null|artist_name:string-|-null|id:number
shape-sig-frequency:apple_music_url:string-|-null|artist_bio:string-|-null|artist_wikipedia_url:string-|-null|artwork_url:string-|-null|bandcamp_url:string-|-null|discogs_url:string-|-null|release_year:number-|-null|soundcloud_url:string-|-null|spotify_url:string-|-null|youtube_music_url:string-|-null
shape-sig-frequency:dryrunreport:dryrunreport-|-null|totals:totals
shape-sig-frequency:id:number
shape-sig-frequency:inlinetracklist:rotationtrack[]-|-null|releaseid:number-|-null
shape-sig-frequency:message:string|skipparsing?:boolean|skipslack?:boolean
shape-sig-frequency:querychunks?:array<string-|-sqlchunk>|raw?:string|sql?:string-|-string[]|values?:unknown[]
shape-sig-frequency:querychunks?:sqlchunk[]|raw?:string|value?:string-|-string[]
shape-sig-frequency:status:number|stderr:string|stdout:string
touched-window-debt-summaryPR-time meta-summary: clusters intersecting the touched-in-window set. 4 row(s), shape: metric. touched-window-debt-summary:exact-duplicates
touched-window-debt-summary:name-collisions
touched-window-debt-summary:cross-package-shadows
touched-window-debt-summary:near-duplicates
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/code-audit-pr-comment.yml— callsjakebromberg/code-audit-pipeline/.github/workflows/pr-comment-reusable.yml@v0.3.2to post a sticky structural-impact comment on every PR (duplicate clusters, cross-package shadows, near-duplicates touched by the diff). Fail-quiet — the audit never blocks a PR..audit/to.gitignoreso the pipeline's runner-temp output never ends up tracked.Notes
@v0.3.2(latest stable). Bump to@v1once the pipeline cuts v1.0.0 — at that point both theuses:ref and theaudit-binary-versioninput can move to a floating major pin.contents: read+pull-requests: writegranted at the workflow level (reusable-workflow permissions are an upper bound, not additive). No new secrets required.Test plan
code-audit-pipeline-v1(so a future re-run edits in place rather than posting again)Closes #1422