fix: ea wpml accordion media type translation#815
Open
ZebaAfiaShama wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected version: 6.6.5
Severity: Low
Summary
The EA Accordion widget's media type fields (image/video) were not being properly registered for WPML translation in the
wpml-config.xmlfile. This caused media-related content in the Accordion widget to not appear in the WPML String Translation panel, preventing translators from translating or syncing media across languages.Reproduction (before fix)
Fix
Updated
wpml-config.xmlto correctly include the EA Accordion widget's media type fields under the proper<node>configuration, ensuring WPML can detect and register them for translation.Test plan
Here's a comprehensive test plan for your WPML Advanced Accordion fix:
TEST PLAN: WPML Translation Fix for Advanced Accordion Media Type Field
Overview
This test plan verifies that the Advanced Accordion widget properly registers its media type fields for WPML translation, allowing language switching to work correctly. It also documents the caching behavior with old pages.
Prerequisites
Test Scenario 1: New Pages with Fixed Plugin (Expected: PASS)
Objective: Verify that newly created pages with the Advanced Accordion widget properly support WPML translation.
Steps:
Expected Result: ✅ All accordion content switches correctly to the selected language without displaying English text.
Test Scenario 2: Old Pages Before Fix (Expected: FAIL without duplication)
Objective: Demonstrate the caching issue with pages created before the plugin fix was uploaded.
Steps:
Expected Result: ❌ Accordion content remains in English even after switching language. WPML has cached the old widget configuration that lacked the media type field registration.
Why This Happens:
Test Scenario 3: Fix for Old Pages Using EA Duplicator (Expected: PASS)
Objective: Verify that duplicating old pages resolves the WPML caching issue.
Prerequisite: Have at least one old page with the accordion widget (from before the fix)
Steps:
Expected Result: ✅ The duplicated page now correctly displays accordion content in the selected language. The fix works as intended.
Why Duplication Works:
Pass/Fail Criteria
PASS:
FAIL:
Notes for QA
Build artifacts
N/A