fix: preserve target attribute on filterable gallery items#813
Open
amin-abir wants to merge 2 commits into
Open
fix: preserve target attribute on filterable gallery items#813amin-abir wants to merge 2 commits into
amin-abir wants to merge 2 commits into
Conversation
DOMPurify was stripping the target attribute from anchor tags, breaking "open in new tab" behavior for gallery links. Allow target via ADD_ATTR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
targetattribute when sanitizing anchor markup in the Filterable Gallery widget, so links configured to open in a new tab continue to do so after sanitization.Test Plan
<a>tag retainstarget="_blank"(andrelif set)Breaking Changes
None.
Pro Repo Coordination
None — change is isolated to Lite's filterable-gallery view script.
Related