refactor(VLE): Remove modules part 2#2246
Merged
Merged
Conversation
… unnecessary RouterModule dep
…alogComponent. Should be re-written from scratch.
…ert lesson before button orientation
…t step before button orientation
❌ 1 blocking issue (1 total)
|
breity
reviewed
Dec 3, 2025
Comment on lines
+28
to
+49
| spyOn(componentTypeService, 'getComponentTypes').and.returnValue([ | ||
| { type: 'AiChat', name: 'AI Chat' }, | ||
| { type: 'Animation', name: 'Animation' }, | ||
| { type: 'AudioOscillator', name: 'Audio Oscillator' }, | ||
| { type: 'ConceptMap', name: 'Concept Map' }, | ||
| { type: 'DialogGuidance', name: 'Dialog Guidance' }, | ||
| { type: 'Discussion', name: 'Discussion' }, | ||
| { type: 'Draw', name: 'Draw' }, | ||
| { type: 'Embedded', name: 'Embedded' }, | ||
| { type: 'Graph', name: 'Graph' }, | ||
| { type: 'Label', name: 'Label' }, | ||
| { type: 'Match', name: 'Match' }, | ||
| { type: 'MultipleChoice', name: 'Multiple Choice' }, | ||
| { type: 'OpenResponse', name: 'Open Response' }, | ||
| { type: 'OutsideURL', name: 'Outside URL' }, | ||
| { type: 'PeerChat', name: 'Peer Chat' }, | ||
| { type: 'HTML', name: 'HTML' }, | ||
| { type: 'ShowGroupWork', name: 'Show Group Work' }, | ||
| { type: 'ShowMyWork', name: 'Show My Work' }, | ||
| { type: 'Summary', name: 'Summary' }, | ||
| { type: 'Table', name: 'Table' } | ||
| ]); |
Member
There was a problem hiding this comment.
Perhaps this could be done without hard-coding. Because we'll need to update whenever a component type is added, removed, or edited, correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 2 of the work to remove modules from WISE-Client and replacing them with standalone components. Also, I removed RoutingModules and replaced them with simple arrays instead. Since the change set has already grown large, I broke up this work into multiple parts to make it easier to review.
Changes
Test