Skip to content

Grade by component show all components#2189

Merged
hirokiterashima merged 18 commits into
grade-by-componentfrom
grade-by-component-show-all-components
Jun 25, 2025
Merged

Grade by component show all components#2189
hirokiterashima merged 18 commits into
grade-by-componentfrom
grade-by-component-show-all-components

Conversation

@hirokiterashima

Copy link
Copy Markdown
Member

(Reminder: this should be a merge commit instead of squash)

Changes

  • Revert to showing all components in the node
  • Revert router so it only goes up to ".../node/nodeId" (before: it included "/component/componentId")
  • Hide summary display (this will be addressed in a separate PR before merging to develop)
  • Add FilterComponentsComponent to let teacher select which components to show
    • Filtering components now updates the status, score and max score column fields appropriately.

Test

  • Node grading works as it currently does in production

@hirokiterashima hirokiterashima self-assigned this May 27, 2025
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label May 27, 2025
@hirokiterashima hirokiterashima marked this pull request as ready for review May 27, 2025 16:37

@breity breity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I updated styles to match mockup.

@hirokiterashima hirokiterashima removed the request for review from Aaron-Detre May 30, 2025 20:46
@hirokiterashima hirokiterashima merged commit 3edd3d1 into grade-by-component Jun 25, 2025
@hirokiterashima hirokiterashima deleted the grade-by-component-show-all-components branch June 25, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants