Skip to content

fix(Grading Tool): Hide detectable ideas if missing rubric data#2167

Merged
Aaron-Detre merged 3 commits into
developfrom
issue-2166-hide-detectable-ideas-if-no-rubric
May 7, 2025
Merged

fix(Grading Tool): Hide detectable ideas if missing rubric data#2167
Aaron-Detre merged 3 commits into
developfrom
issue-2166-hide-detectable-ideas-if-no-rubric

Conversation

@Aaron-Detre

Copy link
Copy Markdown
Contributor

Changes

  • Hide the link to the idea detection rubric if there is no model description and no idea descriptions.
  • Hide the table in the idea detection rubric if there are no idea descriptions.
  • Close the dialog if you leave the step.

Test

  • The three changes above work as described.

Closes #2166

@Aaron-Detre Aaron-Detre self-assigned this May 6, 2025
@Aaron-Detre Aaron-Detre added the bug Something isn't working label May 6, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review May 6, 2025 23:15

@hirokiterashima hirokiterashima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaron-Detre Aaron-Detre merged commit 928bfb6 into develop May 7, 2025
1 check passed
@Aaron-Detre Aaron-Detre deleted the issue-2166-hide-detectable-ideas-if-no-rubric branch May 7, 2025 20:57
@hirokiterashima

Copy link
Copy Markdown
Member

🎉 This PR is included in version 5.181.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(Grading Tool): Hide detectable ideas if missing rubric data

2 participants