Skip to content

Release/v3.0.0#80

Merged
AlexGherardelli merged 42 commits into
mainfrom
release/v3.0.0
May 22, 2026
Merged

Release/v3.0.0#80
AlexGherardelli merged 42 commits into
mainfrom
release/v3.0.0

Conversation

@AlexGherardelli

@AlexGherardelli AlexGherardelli commented May 20, 2026

Copy link
Copy Markdown
Member

Description

  • Update databridgesknots to use data-bridges-client >= 8.0.0 (breaking change)
  • Rename method get_household_xslform_definition to get_household_xlsform_definition (breaking change)
  • Update auth parameters (WFP_API_CLIENT_ID and WFP_API_CLIENT_SECRET), removing SCOPES.
  • Add tests for client, checking both the endpoints we have credentials for and those we are not (403 error expected)
  • Consolidate pyproject.toml for better dependency grouping and removing mentions of other projects ("wfp-survey-toolbox")
  • Make current API version as default param for DataBridgesShapes (no longer need to pass in config)
  • Fix get_market_geojson_list and get_economic_indicator_list endpoint response (respectively return JSON and DataFrame)
  • Add tests for all implemented & working endpoints with API calls
  • Remove deprecated endpoints
  • Update ROADMAP and README

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Comment thread tests/test_client.py Fixed
Comment thread data_bridges_knots/client.py Fixed
Comment thread data_bridges_knots/client.py Fixed
Comment thread data_bridges_knots/client.py Fixed
Comment thread data_bridges_knots/client.py Fixed
Comment thread data_bridges_knots/client.py Fixed
Comment thread data_bridges_knots/client.py Fixed
Comment thread data_bridges_knots/client.py Fixed
@AlexGherardelli AlexGherardelli marked this pull request as ready for review May 21, 2026 14:34
…s not named 'self''

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Comment thread tests/test_client.py Fixed
Comment thread tests/test_client.py Fixed

@paololucchino paololucchino left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlexGherardelli, thanks a lot for this. I have addressed some comments directly via commits. Please have a look and let me know if you have questions / concerns.

Tests are now running but failing. We should try to address these before merging.

@AlexGherardelli AlexGherardelli merged commit 9c6c228 into main May 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hard-code versions of API (with fallback) 404 on get_household_xslform_definition Fix responses on Markets and AIMS endpoints

2 participants